Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r232317090
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
@@ -59,6 +61,31 @@
+ "Note that no flow file input (attributes, e.g.) is
available for use in Expression Language constructs for these properties.")
public class DBCPConnectionPool extends AbstractControllerService
implements DBCPService {
+ /**
+ * Copied from {@link GenericObjectPoolConfig.DEFAULT_MIN_IDLE} in
Commons-DBCP 2.5.0
+ */
+ private static final String DEFAULT_MIN_IDLE = "0";
+ /**
+ * Copied from {@link GenericObjectPoolConfig.DEFAULT_MAX_IDLE} in
Commons-DBCP 2.5.0
+ */
+ private static final String DEFAULT_MAX_IDLE = "8";
+ /**
+ * Copied from private variable {@link
BasicDataSource.maxConnLifetimeMillis} in Commons-DBCP 2.5.0
+ */
+ private static final String DEFAULT_MAX_CONN_LIFETIME = "-1";
+ /**
+ * Copied from {@link
GenericObjectPoolConfig.DEFAULT_TIME_BETWEEN_EVICTION_RUNS_MILLIS} in
Commons-DBCP 2.5.0
+ */
+ private static final String DEFAULT_EVICTION_RUN_PERIOD =
String.valueOf(-1L);
+ /**
+ * Copied from {@link
GenericObjectPoolConfig.DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS} in Commons-DBCP
2.5.0
+ */
+ private static final String DEFAULT_MIN_EVICTABLE_IDLE_TIME =
String.valueOf(1800000L) + " millis";
--- End diff --
Testing on my local instance is looking good so far. One request, can you
change this to `30 min`? A bit easier to read as a default value that way :)
---
