[
https://issues.apache.org/jira/browse/MINIFICPP-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683043#comment-16683043
]
ASF GitHub Bot commented on MINIFICPP-665:
------------------------------------------
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/435
The implementation is fine, I wonder if:
-This all could be done using template member functions
-We could add some more details to commit msg
> Fix basestream references
> -------------------------
>
> Key: MINIFICPP-665
> URL: https://issues.apache.org/jira/browse/MINIFICPP-665
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
>
> At some point basestream was changed to be a composable pointer ( hence the
> name base stream ) as a wrapper for a variety of streams. this caused a bug
> where a self reference could occur. We overload this stream to be a self
> reference since it extends DataStream. This is a very likely usage so we can
> avoid the bugs by simply checking if the composition is a reference to self.
> This reference to self won't be removed in the interest of time and re-using
> Serializable's interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
