[
https://issues.apache.org/jira/browse/NIFI-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684106#comment-16684106
]
ASF GitHub Bot commented on NIFI-5814:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3168
NIFI-5814: Addressed issue in DatabaseReader class that was attemptin…
…g to set values on the JSON returned by MaxMind. Instead of modifying the
object directly, we should use an Injectable in the Reader so that the value
read will have the appropriate values but we don't need to modify those objects
returned by MaxMind
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3168
----
commit 2dee06b599828f417ccddf05096d4afb6343ca42
Author: Mark Payne <markap14@...>
Date: 2018-11-12T17:12:16Z
NIFI-5814: Addressed issue in DatabaseReader class that was attempting to
set values on the JSON returned by MaxMind. Instead of modifying the object
directly, we should use an Injectable in the Reader so that the value read will
have the appropriate values but we don't need to modify those objects returned
by MaxMind
----
> GeoEnrichIP processor fails in 1.8.0
> ------------------------------------
>
> Key: NIFI-5814
> URL: https://issues.apache.org/jira/browse/NIFI-5814
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.8.0
> Reporter: Mark Payne
> Priority: Major
> Fix For: 1.9.0
>
>
> As reported on the mailing list by Philippe Peeters, the GeoEnrichIP
> processor is failing in 1.8.0. This appears to be a caused by a change in the
> version of the maxmind database library. The new version returns JSON objects
> to the DatabaseReader class that are read-only, whereas the previous version
> allowed the objects to be modified. Interestingly, we are modifying the
> object in order to inject in an "ip_address" field in the "Traits" field...
> but then we don't use the field. We can instead just avoid ever modifying the
> response.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
