Github user bdesert commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1953#discussion_r233019686
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -82,12 +94,32 @@
public static final PropertyDescriptor XSLT_FILE_NAME = new
PropertyDescriptor.Builder()
.name("XSLT file name")
- .description("Provides the name (including full path) of the
XSLT file to apply to the flowfile XML content.")
- .required(true)
+ .description("Provides the name (including full path) of the
XSLT file to apply to the flowfile XML content."
+ + "One of the XSLT file name and XSLT controller
properties must be defined.")
+ .required(false)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
.build();
+ public static final PropertyDescriptor XSLT_CONTROLLER = new
PropertyDescriptor.Builder()
+ .name("xslt-controller")
+ .displayName("XSLT controller")
+ .description("Controller used to store XSLT definitions. One
of the XSLT file name and "
+ + "XSLT controller properties must be defined.")
+ .required(false)
+ .identifiesControllerService(StringLookupService.class)
+ .build();
+
+ public static final PropertyDescriptor XSLT_CONTROLLER_KEY = new
PropertyDescriptor.Builder()
+ .name("xslt-controller-key")
+ .displayName("XSLT controller key")
+ .description("Key used to retrieve the XSLT definition from
the XSLT controller. This property must be set when using "
+ + "the XSLT controller property.")
+ .required(false)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
--- End diff --
since this property supports EL, shouldn't it be NON_EMPTY_**EL**_VALIDATOR?
---
