[ 
https://issues.apache.org/jira/browse/NIFI-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685335#comment-16685335
 ] 

ASF GitHub Bot commented on NIFI-4130:
--------------------------------------

Github user bdesert commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1953#discussion_r233016908
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
 ---
    @@ -82,12 +94,32 @@
     
         public static final PropertyDescriptor XSLT_FILE_NAME = new 
PropertyDescriptor.Builder()
                 .name("XSLT file name")
    -            .description("Provides the name (including full path) of the 
XSLT file to apply to the flowfile XML content.")
    -            .required(true)
    +            .description("Provides the name (including full path) of the 
XSLT file to apply to the flowfile XML content."
    +                    + "One of the XSLT file name and XSLT controller 
properties must be defined.")
    +            .required(false)
                 
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
                 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor XSLT_CONTROLLER = new 
PropertyDescriptor.Builder()
    +            .name("xslt-controller")
    +            .displayName("XSLT controller")
    --- End diff --
    
    "XSLT Lookup" Would be more readable. 
    Description: "Lookup controller used to store..."
    And: XSLT_CONTROLLER_KEY: "XSLT Lookup Key" (description looks fine)


> TransformXml - provide a way to define XSLT without external files
> ------------------------------------------------------------------
>
>                 Key: NIFI-4130
>                 URL: https://issues.apache.org/jira/browse/NIFI-4130
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Major
>
> In cluster deployments the need to reference external configuration files can 
> be annoying since it requires to access to all the NiFi nodes and to 
> correctly deploy the files. It would be interesting to leverage the lookup 
> controller services in TransformXml to provide a way to define XSLT directly 
> from the UI without external configuration files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to