Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/435#discussion_r232960242
--- Diff: libminifi/src/io/BaseStream.cpp ---
@@ -143,15 +147,19 @@ int BaseStream::read(uint8_t *value, int len) {
* @param buflen
*/
int BaseStream::readData(std::vector<uint8_t> &buf, int buflen) {
- return Serializable::read(&buf[0], buflen,
reinterpret_cast<DataStream*>(composable_stream_));
+ return Serializable::read(&buf[0], buflen, composable_stream_);
}
/**
* Reads data and places it into buf
* @param buf buffer in which we extract data
* @param buflen
*/
int BaseStream::readData(uint8_t *buf, int buflen) {
- return Serializable::read(buf, buflen,
reinterpret_cast<DataStream*>(composable_stream_));
+ if (composable_stream_ == this) {
--- End diff --
Likely?
---
