Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233911949
  
    --- Diff: nanofi/include/core/cstructs.h ---
    @@ -76,6 +80,12 @@ typedef struct {
      * ##################################################################
      */
     
    +typedef struct{
    +  char *key;
    --- End diff --
    
    I'll add that I'm not against this, but the code pointer's management was a 
little different. Again, I'll take a look at if this makes sense. core will be 
things that don't reflect a user experience though. That is code that's not 
part of our public API. 


---

Reply via email to