[
https://issues.apache.org/jira/browse/NIFI-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688543#comment-16688543
]
ASF GitHub Bot commented on NIFI-5824:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3173
NIFI-5824: Added unit test to FlowController to ensure that the Proce…
…ssScheduler that it creates is properly initialized. Also updated the
properties file used by TestFlowController to use a VolatileContentRepository
instead of FileSystemRepository, and fixed EventDrivenWorkerQueue to return if
calls to poll() are interrupted (via Thread.interrupt) - making these minor
fixes resulted in the unit test TestFlowController running in 2 seconds instead
of 30+ seconds on my machine
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5824
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3173
----
commit ecdcbba8d31af75b3406f336e5272ec3e9a2be21
Author: Mark Payne <markap14@...>
Date: 2018-11-15T19:26:36Z
NIFI-5824: Added unit test to FlowController to ensure that the
ProcessScheduler that it creates is properly initialized. Also updated the
properties file used by TestFlowController to use a VolatileContentRepository
instead of FileSystemRepository, and fixed EventDrivenWorkerQueue to return if
calls to poll() are interrupted (via Thread.interrupt) - making these minor
fixes resulted in the unit test TestFlowController running in 2 seconds instead
of 30+ seconds on my machine
----
> Add test to FlowController to ensure that NIFI-5822 is properly resolved
> ------------------------------------------------------------------------
>
> Key: NIFI-5824
> URL: https://issues.apache.org/jira/browse/NIFI-5824
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.9.0
>
>
> While the fix for NIFI-5822 has been merged and addresses the issue, it would
> be helpful to have a unit test to verify it, so that we can ensure that we
> never get into this situation again. It's a slight change that could easily
> be undone in the future and it's not obvious until specific processors
> attempt to run. We should have a unit test to verify that the Process
> Scheduler is able to properly access the ControllerServiceProvider
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
