[
https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692509#comment-16692509
]
ASF GitHub Bot commented on MINIFICPP-679:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/444
MINIFICPP-679: Revert changes. We can make them const but we should w…
…ait after additional testing before pushing these changes
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-679-b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 7d239c5c449480349852dc40751f163dee62a277
Author: Marc Parisi <phrocker@...>
Date: 2018-11-20T01:05:23Z
MINIFICPP-679: Revert changes. We can make them const but we should wait
after additional testing before pushing these changes
----
> Improve Const correctness in core, configurable component, and ID
> -----------------------------------------------------------------
>
> Key: MINIFICPP-679
> URL: https://issues.apache.org/jira/browse/MINIFICPP-679
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
> Fix For: 0.6.0
>
>
> Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 .
>
> This one scares me a tad. anytime we touch base classes , this will have an
> impact on release cadence. So this one will require a lot of testing across
> platforms, compilers, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
