[
https://issues.apache.org/jira/browse/NIFI-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693875#comment-16693875
]
ASF GitHub Bot commented on NIFI-5834:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3179
NIFI-5834: Restore default PutHiveQL error handling behavior
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3179
----
commit 3e1b98b74476bc534f7039580cfde25bd733e773
Author: Matthew Burgess <mattyb149@...>
Date: 2018-11-20T22:58:59Z
NIFI-5834: Restore default PutHiveQL error handling behavior
----
> Restore default PutHiveQL error handling behavior
> -------------------------------------------------
>
> Key: NIFI-5834
> URL: https://issues.apache.org/jira/browse/NIFI-5834
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> As part of adding Rollback On Failure to PutHiveQL (via NIFI-3415), the code
> was refactored to allow failures to be rolled back rather than transferred to
> the failure relationship (if Rollback On Failure is set). As part of that,
> all transient SQLExceptions were declared to be of type "Temporal Failure".
> This (along with the refactor) allowed the failures to be handled as
> rollbacks or transfers as specified.
> Hive returns all exceptions as transient SQLExceptions, with an error code
> that better infers the behavior of the operation. This, via the discovery of
> NIFI-5045, resulted in the handling of error codes within the Hive error code
> range. However the default behavior when the error code is not in the
> Hive-valid range is to rollback regardless of whether Rollback On Failure is
> true or not. This was done as a "better safe than sorry" approach, but it
> made the behavior inconsistent with earlier versions of the processor, where
> failures were simply routed to failure rather than rolling back.
> This case proposes to return the default behavior for unknown SQLExceptions
> to "TemporalFailure", which will make the behavior consistent with previous
> versions of the processor, where unknown errors will be transferred to
> failure unless Rollback on Failure is true.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
