Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3180#discussion_r235417790
--- Diff:
nifi-nar-bundles/nifi-social-media-bundle/nifi-twitter-processors/src/main/java/org/apache/nifi/processors/twitter/GetTwitter.java
---
@@ -56,24 +67,10 @@
import org.apache.nifi.processor.io.OutputStreamCallback;
import org.apache.nifi.processor.util.StandardValidators;
-import com.twitter.hbc.ClientBuilder;
-import com.twitter.hbc.core.Client;
-import com.twitter.hbc.core.Constants;
-import com.twitter.hbc.core.endpoint.Location ;
-import com.twitter.hbc.core.endpoint.Location.Coordinate ;
-import com.twitter.hbc.core.endpoint.StatusesFilterEndpoint;
-import com.twitter.hbc.core.endpoint.StatusesFirehoseEndpoint;
-import com.twitter.hbc.core.endpoint.StatusesSampleEndpoint;
-import com.twitter.hbc.core.endpoint.StreamingEndpoint;
-import com.twitter.hbc.core.event.Event;
-import com.twitter.hbc.core.processor.StringDelimitedProcessor;
-import com.twitter.hbc.httpclient.auth.Authentication;
-import com.twitter.hbc.httpclient.auth.OAuth1;
-
@SupportsBatching
@InputRequirement(Requirement.INPUT_FORBIDDEN)
@Tags({"twitter", "tweets", "social media", "status", "json"})
-@CapabilityDescription("Pulls status changes from Twitter's streaming API")
+@CapabilityDescription("Pulls status changes from Twitter's streaming API.
In versions starting with 1.9.0, the Consumer Key and Access Token are marked
as sensitive according to
https://developer.twitter.com/en/docs/basics/authentication/guides/securing-keys-and-tokens";)
--- End diff --
i think it probably makes sense to leave it here because that link in
general is good for users to read and it is more of a higher level concern that
the secrets and tokens should be sensitive. Dont have a strong opinion on this
but given your +1 koji already i'm going to go ahead and merge this thing as-is
after removing the flagged todo.
---
