[
https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694993#comment-16694993
]
ASF GitHub Bot commented on NIFI-5836:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/3181
NIFI-5836 changed the brittle timing based tests to integration tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-5836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3181
----
commit 7201f2c018b3fff31e70175fb7bb300bc46e0e31
Author: joewitt <joewitt@...>
Date: 2018-11-21T17:26:13Z
NIFI-5836 changed the brittle timing based tests to integration tests
----
> TestHandleHttpRequest is making the travis builds very brittle
> --------------------------------------------------------------
>
> Key: NIFI-5836
> URL: https://issues.apache.org/jira/browse/NIFI-5836
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Priority: Critical
>
> Seeing these consistently on various travis builds. These should likely be IT
> [ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 60.369 s <<< FAILURE! - in
> org.apache.nifi.processors.standard.TestHandleHttpRequest
> [ERROR]
> testRequestAddedToService(org.apache.nifi.processors.standard.TestHandleHttpRequest)
> Time elapsed: 30.144 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 30000
> milliseconds
> at
> org.apache.nifi.processors.standard.TestHandleHttpRequest.testRequestAddedToService(TestHandleHttpRequest.java:152)
> ERROR] Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 60.449
> s <<< FAILURE! - in org.apache.nifi.processors.standard.TestHandleHttpRequest
> [ERROR]
> testMultipartFormDataRequest(org.apache.nifi.processors.standard.TestHandleHttpRequest)
> Time elapsed: 30.019 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 30000
> milliseconds
> at
> org.apache.nifi.processors.standard.TestHandleHttpRequest.testMultipartFormDataRequest(TestHandleHttpRequest.java:271)
> [ERROR]
> testMultipartFormDataRequestFailToRegisterContext(org.apache.nifi.processors.standard.TestHandleHttpRequest)
> Time elapsed: 30.005 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 30000
> milliseconds
> at
> org.apache.nifi.processors.standard.TestHandleHttpRequest.testMultipartFormDataRequestFailToRegisterContext(TestHandleHttpRequest.java:337)
> [ERROR]
> testFailToRegister(org.apache.nifi.processors.standard.TestHandleHttpRequest)
> Time elapsed: 30.015 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 30000
> milliseconds
> at
> org.apache.nifi.processors.standard.TestHandleHttpRequest.testFailToRegister(TestHandleHttpRequest.java:424)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
