Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236665802
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return vector of property keys
*/
- std::vector<std::string> getDynamicPropertyKeys();
+ std::vector<std::string> getDynamicPropertyKeys() const;
/**
* Returns a vector all properties
*
* @return map of property keys to Property instances.
*/
- std::map<std::string, Property> getProperties();
+ std::map<std::string, Property> getProperties() const;
--- End diff --
Nope, the map is created upon execution, (a merge of dynamic and static
properties), so there is no real point in returning const ref.
---
