[
https://issues.apache.org/jira/browse/MINIFICPP-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700433#comment-16700433
]
ASF GitHub Bot commented on MINIFICPP-685:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236665802
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return vector of property keys
*/
- std::vector<std::string> getDynamicPropertyKeys();
+ std::vector<std::string> getDynamicPropertyKeys() const;
/**
* Returns a vector all properties
*
* @return map of property keys to Property instances.
*/
- std::map<std::string, Property> getProperties();
+ std::map<std::string, Property> getProperties() const;
--- End diff --
Nope, the map is created upon execution, (a merge of dynamic and static
properties), so there is no real point in returning const ref.
> Improve const correctness of property getters
> ---------------------------------------------
>
> Key: MINIFICPP-685
> URL: https://issues.apache.org/jira/browse/MINIFICPP-685
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Arpad Boda
> Assignee: Arpad Boda
> Priority: Minor
> Fix For: 0.6.0
>
>
> Most of property getters are non-const, but they should be.
> Virtual functions shouldn't be modified in minor release, the rest can be
> fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
