Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/148#discussion_r236849392
  
    --- Diff: 
nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java
 ---
    @@ -0,0 +1,161 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.extension;
    +
    +import io.swagger.annotations.ApiModel;
    +import io.swagger.annotations.ApiModelProperty;
    +import org.apache.nifi.registry.link.LinkableEntity;
    +
    +import javax.validation.constraints.Min;
    +import javax.validation.constraints.NotBlank;
    +import javax.xml.bind.annotation.XmlRootElement;
    +import java.util.Objects;
    +
    +@ApiModel
    +@XmlRootElement
    +public class ExtensionBundleVersionMetadata extends LinkableEntity 
implements Comparable<ExtensionBundleVersionMetadata> {
    +
    +    @NotBlank
    +    private String id;
    +
    +    @NotBlank
    +    private String extensionBundleId;
    +
    +    @NotBlank
    +    private String bucketId;
    +
    +    @NotBlank
    +    private String version;
    +
    +    private ExtensionBundleVersionDependency dependency;
    +
    +    @Min(1)
    +    private long timestamp;
    +
    +    @NotBlank
    +    private String author;
    +
    +    private String description;
    +
    +    @NotBlank
    +    private String sha256Hex;
    --- End diff --
    
    @kevdoran I'm good with calling it sha256 for consistency
    
    @alopresto It is fairly straight forward to add another field here, just 
typical changes like DB schema update, new member field, modify mapping code 
(no ORM here :( ). Right now the input of the SHA-256 is the binary content of 
the bundle (i.e. the input stream of actual NAR file). 
    
    Did you want me to add in the cryptographic signature in this PR (assuming 
you point at how to calculate it), or do you want to wait til this is merged 
and add as follow on work? 
    
    It can be done either way, there is still a bit more work to do before this 
is ready anyway.


---

Reply via email to