[
https://issues.apache.org/jira/browse/NIFI-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702082#comment-16702082
]
ASF subversion and git services commented on NIFI-5843:
-------------------------------------------------------
Commit 98cdb50cc0a72957959188d352b9507d4f85dea1 in nifi's branch
refs/heads/master from [~alex_savitsky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=98cdb50 ]
NIFI-5843 added subjects to the error message when neither script body nor
script text are provided
Signed-off-by: Matthew Burgess <[email protected]>
This closes #3186
> Unclear validation message for ScriptingComponentHelper
> -------------------------------------------------------
>
> Key: NIFI-5843
> URL: https://issues.apache.org/jira/browse/NIFI-5843
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Alex Savitsky
> Priority: Trivial
> Fix For: 1.9.0
>
>
> ScriptingComponentHelper.customValidate (from nifi-scripting-processors)
> creates an unclear validation message
> {quote}'' is invalid because Exactly one of Script File or Script Body must
> be set
> {quote}
> as it doesn't specify the validation subject. Since there are technically two
> invalid subjects in this case (Script File and Script Body), I suggest adding
> two validation messages, one for each subject.
> Current code:
> {code:java}
> results.add(new ValidationResult.Builder().valid(false).explanation(
> "Exactly one of Script File or Script Body must be set").build());
> {code}
> Proposed fix:
> {code:java}
> results.add(new ValidationResult.Builder().subject("Script
> Body").valid(false).explanation(
> "exactly one of Script File or Script Body must be set").build());
> results.add(new ValidationResult.Builder().subject("Script
> File").valid(false).explanation(
> "exactly one of Script File or Script Body must be set").build());
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
