[
https://issues.apache.org/jira/browse/NIFI-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702872#comment-16702872
]
ASF GitHub Bot commented on NIFI-5849:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/3189
NIFI-5849: ListXXX can lose cluster state on processor restart
NIFI-5406 introduced the issue by trying to use the resetState variable for
different purposes. AbstractListProcessor should have had a different
variable
to control whether to clear state for tracking entity strategy.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5849
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3189
----
commit 6dac106dc1c8c946db9dce7a5be9b7769a7ea6c8
Author: Koji Kawamura <ijokarumawak@...>
Date: 2018-11-29T08:44:44Z
NIFI-5849: ListXXX can lose cluster state on processor restart
NIFI-5406 introduced the issue by trying to use the resetState variable for
different purposes. AbstractListProcessor should have had a different
variable
to control whether to clear state for tracking entity strategy.
----
> ListSFTP, ListFTP processors lose Cluster state on restart.
> -----------------------------------------------------------
>
> Key: NIFI-5849
> URL: https://issues.apache.org/jira/browse/NIFI-5849
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Truong Duc Kien
> Assignee: Koji Kawamura
> Priority: Critical
>
> In a cluster environment, restarting a processor that extends
> {{AbstractListProcessor}} could lead to the erasure of that processor's
> existing cluster states.
> This bug was introduced in commit
> [https://github.com/apache/nifi/commit/8b9d4461185848fd552a639ac14b7926164d5426]
> .
> Before that commit, the {{resetState}} variable is changed to false after the
> state is clear, inside {{updateState}} method. However, the commit moved this
> line to inside the {{onTrigger}} method. This is problematic, because
> {{onTrigger}} method is only called on the primary node. As a result, the
> {{resetState}} variable is only reset to false on primary node, but not on
> the other nodes. When the user restarts the processor, every nodes will
> re-execute the {{updateState}} method and the Cluster state will be cleared.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
