Github user amcdonaldccri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2968#discussion_r237865566
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java
---
@@ -286,7 +286,7 @@ protected void
initializeRegionAndEndpoint(ProcessContext context) {
final String urlstr =
StringUtils.trimToEmpty(context.getProperty(ENDPOINT_OVERRIDE).evaluateAttributeExpressions().getValue());
if (!urlstr.isEmpty()) {
getLogger().info("Overriding endpoint with {}", new
Object[]{urlstr});
- this.client.setEndpoint(urlstr);
+ this.client.setEndpoint(urlstr,
this.client.getServiceName(), this.region.getName());
--- End diff --
Using this.region.getName() doesn't make sense to me because the aws docs
for
public void setEndpoint(String endpoint, String serviceName, String
regionId)
say
* @param regionId
* The ID of the region in which this service resides AND the
* overriding region for signing purposes.
so the regionId is the same as the overriding region but using this.region
is using the enum.
---
