Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239117109 --- Diff: libminifi/include/Exception.h --- @@ -60,16 +60,17 @@ class Exception : public std::exception { public: // Constructor /*! - * Create a new flow record + * Create a new exception */ - Exception(ExceptionType type, const char *errorMsg) + Exception(ExceptionType type, std::string errorMsg) : _type(type), - _errorMsg(errorMsg) { + _errorMsg(std::move(errorMsg)) { --- End diff -- Just saw this when I was typing the one below, I'll run the build before merging obviously, but does this not generate an elision warning?
---