[ https://issues.apache.org/jira/browse/MINIFICPP-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710244#comment-16710244 ]
ASF GitHub Bot commented on MINIFICPP-689: ------------------------------------------ Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239117254 --- Diff: libminifi/include/Exception.h --- @@ -60,16 +60,17 @@ class Exception : public std::exception { public: // Constructor /*! - * Create a new flow record + * Create a new exception */ - Exception(ExceptionType type, const char *errorMsg) + Exception(ExceptionType type, std::string errorMsg) : _type(type), - _errorMsg(errorMsg) { + _errorMsg(std::move(errorMsg)) { } + // Destructor - virtual ~Exception() throw () { + virtual ~Exception() noexcept { --- End diff -- I didn't notice that throw was here. Odd choice. The compiler usually generates an implicit noexcept unless told otherwise, so I'm tempted to do a little more testing of this across compilers. I'll do this before merge. > Make minifi::Exception constructible with string param > ------------------------------------------------------ > > Key: MINIFICPP-689 > URL: https://issues.apache.org/jira/browse/MINIFICPP-689 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Arpad Boda > Assignee: Arpad Boda > Priority: Minor > Fix For: 0.6.0 > > > Exception is currently only constructible using const char * argument, but > that's copied into a string. Using string parameter would make it more > developer-friendly and save some copy constructions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)