[
https://issues.apache.org/jira/browse/NIFI-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710583#comment-16710583
]
ASF GitHub Bot commented on NIFI-1364:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/3204
NIFI-1364 - Removed custom OCSP certificate revocation checking code and
replaced with just using Java native implementation.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi ocsp_changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3204
----
commit ae351199c0b0a1edd54670846e1aef45427ca1a7
Author: thenatog <thenatog@...>
Date: 2018-11-16T02:52:05Z
OCSP revocation checking working
commit 143ab823bdcd58830a11ab17e655e5ee7ba34e09
Author: thenatog <thenatog@...>
Date: 2018-11-21T15:32:05Z
Added OCSP enable setting to NiFi properties.
commit 4dd438fe02f5968e70382d43c9c01c1f003b6a94
Author: thenatog <thenatog@...>
Date: 2018-12-03T14:44:53Z
Added groovy tests
commit 0d3f837a4aa11517e0fca875914a99cbed20dde2
Author: thenatog <thenatog@...>
Date: 2018-12-03T19:13:16Z
Fixed some tests
commit 35e45e080e353c55d47e22400df285fb7cc65f0d
Author: thenatog <thenatog@...>
Date: 2018-12-03T20:17:55Z
Removed some references to old OCSP cert validator
commit a85a10656e95369e97fd88ad3c0c8a29481b654f
Author: thenatog <thenatog@...>
Date: 2018-12-03T22:03:55Z
Backed out changes to the SslContextFactory used for SslContextService
commit 932d32480ca82e00ca71314a2fdc3f74ac3eeb14
Author: thenatog <thenatog@...>
Date: 2018-12-04T15:25:20Z
Minor changes
commit 0b50a806d29ea274c24e9be4c7a8f97641fedd3a
Author: thenatog <thenatog@...>
Date: 2018-12-05T03:08:30Z
Small changes
commit 0d62efacf3c3f8cf551b2020fe3dd233e3e920d9
Author: thenatog <thenatog@...>
Date: 2018-12-05T15:52:47Z
Set custom responder URL if it's set in NiFiProperties.
----
> Audit OCSP certificate validation
> ---------------------------------
>
> Key: NIFI-1364
> URL: https://issues.apache.org/jira/browse/NIFI-1364
> Project: Apache NiFi
> Issue Type: Task
> Components: Core Framework
> Affects Versions: 0.4.1
> Reporter: Andy LoPresto
> Assignee: Nathan Gough
> Priority: Major
> Labels: certificate, ocsp, security
>
> While upgrading the version of BouncyCastle libraries used, I had to re-write
> the OCSP certificate validation code because BC split the PKIX code into a
> separate module and renamed many classes & methods. During this re-write, I
> made the code compile using the new logic, but I am unsure that OCSP
> validation needs to occur outside of the SSL/TLS negotiation, or that the
> current mechanism is correct.
> Questions:
> * Can we use Java's built-in OCSP validation? [1][2]
> * Is the current mechanism correct, where a local cache is used with custom
> internal classes representing OCSP requests and statuses, and it queries a
> pre-specified OCSP responder as opposed to the per-certificate OCSP responder
> listed in each certificate's Authority Information Access OCSP URI [3]? I
> think this design decision stems from a legacy environment which may not
> apply to current use cases.
> More information: [4]
> [1] https://blogs.oracle.com/xuelei/entry/enable_ocsp_checking
> [2]
> https://stackoverflow.com/questions/8506661/check-x509-certificate-revocation-status-in-spring-security-before-authenticatin
> [3]
> https://blog.ivanristic.com/2014/02/checking-ocsp-revocation-using-openssl.html
> [4]
> https://raymii.org/s/articles/OpenSSL_Manually_Verify_a_certificate_against_an_OCSP.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
