GitHub user wselwood opened a pull request:
https://github.com/apache/nifi/pull/3205
NIFI-5875 Improve docs around the PriorityAttributePrioritizer
Clear up the documentation around the PriorityAttributePrioritizer to make
it clearer that if the attributes are both number the largest wins but if they
are not numbers they sort the other way around.
I had to go and look at the code to work out what was going on after
reading the existing documentation.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wselwood/nifi patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3205
----
commit 529c066c7247b5467ce1274c28539dcabb8acfb7
Author: Wil Selwood <wselwood@...>
Date: 2018-12-06T10:17:19Z
Improve docs around the PriorityAttributePrioritizer
Clear up the documentation around the PriorityAttributePrioritizer to make
it clearer that if the attributes are both number the largest wins but if they
are not numbers they sort the other way around.
I had to go and look at the code to work out what was going on after
reading the existing documentation.
----
---
