[
https://issues.apache.org/jira/browse/MINIFICPP-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712699#comment-16712699
]
ASF GitHub Bot commented on MINIFICPP-691:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239776939
--- Diff: extensions/mqtt/processors/AbstractMQTTProcessor.h ---
@@ -157,7 +157,6 @@ class AbstractMQTTProcessor : public core::Processor {
std::string securityPrivateKeyPassWord_;
};
-REGISTER_RESOURCE(AbstractMQTTProcessor);
--- End diff --
Good spot, however could you make the class abstact, too?
(REGISTER_RESOURCE fails to compile in case the argument is abstact class, so
it makes sure it doesn't happen again)
I'm also wondering whet making "Processor" abstact would make sense or not.
If you create a follow-up Jira, I can do as well.
> Improve method of gathering processor documentation and providing to C2
> -----------------------------------------------------------------------
>
> Key: MINIFICPP-691
> URL: https://issues.apache.org/jira/browse/MINIFICPP-691
> Project: NiFi MiNiFi C++
> Issue Type: Task
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
> Labels: documentation
> Fix For: 0.6.0
>
>
> Improve method of gathering processor documentation and providing to C2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
