[
https://issues.apache.org/jira/browse/MINIFICPP-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712776#comment-16712776
]
ASF GitHub Bot commented on MINIFICPP-693:
------------------------------------------
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/458
MINIFICPP-693 - getProperty should rely on user provided allocated bu…
…ffers.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-693
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #458
----
commit 3d8f60d44e92cf5d384a8c6b24fc2a12e42ebbc4
Author: Arpad Boda <aboda@...>
Date: 2018-12-07T12:30:10Z
MINIFICPP-693 - getProperty should rely on user provided allocated buffers.
----
> getProperty should rely on user provided allocated buffers.
> ------------------------------------------------------------
>
> Key: MINIFICPP-693
> URL: https://issues.apache.org/jira/browse/MINIFICPP-693
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Arpad Boda
> Priority: Major
> Labels: nanofi
>
> Assuming this is a provision from the current release we should be able to
> change this to getproperty(XXX,user pntr, user provided size) and leave
> allocation up to the consumer. This will likely be more C prototypical and
> congruent with where the API is headed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
