[ https://issues.apache.org/jira/browse/NIFI-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713019#comment-16713019 ]
ASF GitHub Bot commented on NIFI-5884: -------------------------------------- GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/3211 NIFI-5884 Bumping hbase-client version from 1.1.2 to 1.1.13 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-5884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3211 ---- commit 86d86f7fcd3e27e4dde102751dec47d4c2159684 Author: Bryan Bende <bbende@...> Date: 2018-12-07T15:50:43Z NIFI-5884 Bumping hbase-client version from 1.1.2 to 1.1.13 ---- > Use latest 1.1.x HBase client > ----------------------------- > > Key: NIFI-5884 > URL: https://issues.apache.org/jira/browse/NIFI-5884 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Bryan Bende > Assignee: Bryan Bende > Priority: Minor > > I've seen a scenario where the HBase_1_1_2_ClientService got stuck in the > disabling state and was never going to complete due to the close() method of > the client being stuck in this while loop: > https://github.com/apache/hbase/blob/rel/1.1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java#L1168 > It appears this was a know issue and resolved in HBase client 1.1.6, and I > believe the latest is now 1.1.13: > https://issues.apache.org/jira/browse/HBASE-15957 > Previously I was against changing from 1.1.2 since the controller service has > the version in the name, but after seeing actual bugs impacting the service, > I am now in favor of changing to the latest 1.1.x version, knowing that we > still need to eventually implement a 2.x version of the service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)