[ 
https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719452#comment-16719452
 ] 

ASF GitHub Bot commented on NIFIREG-215:
----------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/149#discussion_r241190389
  
    --- Diff: 
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionResource.java
 ---
    @@ -93,15 +94,25 @@ public ExtensionResource(final RegistryService 
registryService,
                 responseContainer = "List"
         )
         @ApiResponses({ @ApiResponse(code = 401, message = 
HttpStatusMessages.MESSAGE_401) })
    -    public Response getExtensionBundles() {
    +    public Response getExtensionBundles(
    +            @QueryParam("groupId")
    +            @ApiParam("Optional groupId to filter results. The value may 
be an exact match, or a trailing wildcard, " +
    +                    "such as 'com.%' to select all bundles where the 
groupId starts with 'com.'.")
    +                final String groupId,
    +            @QueryParam("artifactId")
    +            @ApiParam("Optional artifactId to filter results. The value 
may be an exact match, or a trailing wildcard, " +
    +                    "such as 'nifi-%' to select all bundles where the 
artifactId starts with 'nifi-'.")
    +                final String artifactId) {
    --- End diff --
    
    Good call, I hadn't really thought about how the SQL 'LIKE' was working and 
I was only really testing trailing wildcards, but you're right, I can remove 
that from the docs.


> Extension Bundle Improvements
> -----------------------------
>
>                 Key: NIFIREG-215
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-215
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>              Labels: Extension_Registry
>             Fix For: 0.4.0
>
>
> This ticket is to implement some additional improvements to the work done in 
> NIFIREG-211.
>  * Store file size of a bundle in the DB and make it available in retrieved 
> objects
>  * Provide a method to check if a bundle exists (true or false)
>  * Provide an option to allow uploading and overwriting an existing bundle
>  * Consider making snapshots a special version that can always be overridden



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to