alopresto commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r244899214
########## File path: nifi-fn/pom.xml ########## @@ -0,0 +1,145 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.nifi.fn</groupId> + <artifactId>nifi-fn</artifactId> + <version>1.0-SNAPSHOT</version> Review comment: I think you would want to change this to three-component versioning as we follow [_semantic versioning_](https://semver.org/). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
