pvillard31 commented on a change in pull request #3240: NIFI-5921: Added
property to allow a user to define a timeout on the ConsumeJMS …
URL: https://github.com/apache/nifi/pull/3240#discussion_r245116919
##########
File path:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
##########
@@ -128,6 +129,13 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ static final PropertyDescriptor TIMEOUT = new PropertyDescriptor.Builder()
+ .name("Timeout")
+ .description("How long to wait to consume a message from the
remote broker before giving up.")
+ .required(true)
+ .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+ .defaultValue("1 sec")
Review comment:
I don't believe this is the current behavior. To ensure backward
compatibility, I believe this should be set to '0 sec' (which indicates a
blocking receive without timeout).
```suggestion
.defaultValue("0 sec")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
