phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533
##########
File path: libminifi/test/unit/PropertyTests.cpp
##########
@@ -107,3 +107,28 @@ TEST_CASE("Test Trimmer Left", "[testTrims]") {
REQUIRE(test.c_str()[1] == ' ');
}
+TEST_CASE("Test int conversion", "[testStringToInt]") {
Review comment:
Almost all of these are invalid and shouldn't be accepted, though. This was
the point of https://issues.apache.org/jira/browse/MINIFICPP-707. I don't want
to trounce on this PR, but the reason I created the ticket was that some of
these SHOULD be prevented from being used at all in configs, fail early.
Therefore it's not as simple as doing what is done here. 710 should be OBE in
favor of 707. There needs to be more thought put into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
