phrocker commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r246921592
##########
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##########
@@ -394,98 +394,12 @@ bool
RawSiteToSiteClient::getPeerList(std::vector<PeerStatus> &peers) {
return false;
}
}
-
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
Review comment:
^ Same as comments above, This can stay and we can remove the duplicate in
the base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
