phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246973810
##########
File path: libminifi/test/unit/PropertyTests.cpp
##########
@@ -107,3 +107,28 @@ TEST_CASE("Test Trimmer Left", "[testTrims]") {
REQUIRE(test.c_str()[1] == ' ');
}
+TEST_CASE("Test int conversion", "[testStringToInt]") {
+ using org::apache::nifi::minifi::core::Property;
+
+ uint64_t uint64_var = 0;
+ REQUIRE(Property::StringToInt("-2", uint64_var) == false); // Negative
shouldn't be converted to uint
+
+ uint32_t uint32_var = 0;
+ REQUIRE(Property::StringToInt("3 GB", uint32_var) == true); // Test
skipping of spaces, too
Review comment:
Some of these tests exist in yaml if I recall correctly ( but I didn't write
them ), if you're interested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
