[ 
https://issues.apache.org/jira/browse/NIFIREG-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFIREG-222:
--------------------------------
    Description: 
h2. Working dir

In 
[RunNiFiRegistry.java|https://github.com/apache/nifi-registry/blob/6f26290d78ffb3a7cf0ba44ef62346f55960054c/nifi-registry-core/nifi-registry-bootstrap/src/main/java/org/apache/nifi/registry/bootstrap/RunNiFiRegistry.java#L835],
 there is problematic logic deriving the default working dir. It assumes the 
bootstrap.conf file's parent's parent is the NiFi Registry home directory. The 
problem with this is that (1) the conf dir may be externalized and (2) 
everywhere else in the code uses the NIFI_REGISTRY_HOME env variable. Lastly, 
the property that can be used to override this default with an explicit 
location, {{working.dir=}} is not in the template bootstrap.conf with 
documentation for how it works.

This should be corrected.


h2. Docs dir

The location of the NiFi Registry docs dir is a hardcoded relative path at 
[JettyServer.java#L376|https://github.com/apache/nifi-registry/blob/6f26290d78ffb3a7cf0ba44ef62346f55960054c/nifi-registry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java#L376].

The other directories the are relevant to the NiFi Registry runtime environment 
are externally configurable via properties and environment variables.

This should be modified to allow for overriding the docs directory location. It 
can still default to the current (hardcoded, unchangeable) location if an 
override is not specified explicitly.

  was:
The location of the NiFi Registry docs dir is a hardcoded relative path at 
[JettyServer.java#L376|https://github.com/apache/nifi-registry/blob/6f26290d78ffb3a7cf0ba44ef62346f55960054c/nifi-registry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java#L376].

The other directories the are relevant to the NiFi Registry runtime environment 
are externally configurable via properties and environment variables.

This should be modified to allow for overriding the docs directory location. It 
can still default to the current (hardcoded, unchangeable) location if an 
override is not specified explicitly.


> NiFi Registry Working dir and docs dir logic
> --------------------------------------------
>
>                 Key: NIFIREG-222
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-222
>             Project: NiFi Registry
>          Issue Type: Bug
>            Reporter: Kevin Doran
>            Priority: Major
>             Fix For: 0.4.0
>
>
> h2. Working dir
> In 
> [RunNiFiRegistry.java|https://github.com/apache/nifi-registry/blob/6f26290d78ffb3a7cf0ba44ef62346f55960054c/nifi-registry-core/nifi-registry-bootstrap/src/main/java/org/apache/nifi/registry/bootstrap/RunNiFiRegistry.java#L835],
>  there is problematic logic deriving the default working dir. It assumes the 
> bootstrap.conf file's parent's parent is the NiFi Registry home directory. 
> The problem with this is that (1) the conf dir may be externalized and (2) 
> everywhere else in the code uses the NIFI_REGISTRY_HOME env variable. Lastly, 
> the property that can be used to override this default with an explicit 
> location, {{working.dir=}} is not in the template bootstrap.conf with 
> documentation for how it works.
> This should be corrected.
> h2. Docs dir
> The location of the NiFi Registry docs dir is a hardcoded relative path at 
> [JettyServer.java#L376|https://github.com/apache/nifi-registry/blob/6f26290d78ffb3a7cf0ba44ef62346f55960054c/nifi-registry-core/nifi-registry-jetty/src/main/java/org/apache/nifi/registry/jetty/JettyServer.java#L376].
> The other directories the are relevant to the NiFi Registry runtime 
> environment are externally configurable via properties and environment 
> variables.
> This should be modified to allow for overriding the docs directory location. 
> It can still default to the current (hardcoded, unchangeable) location if an 
> override is not specified explicitly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to