[GitHub] ekovacs commented on a change in pull request #3282: NIFI-5983: handling parse problems in recordReader implementations

[GitBox]

ekovacs commented on a change in pull request #3282: NIFI-5983: handling parse 
problems in recordReader implementations
URL: https://github.com/apache/nifi/pull/3282#discussion_r252976097
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroRecordReader.java
 ##########
 @@ -24,6 +24,8 @@
 import org.apache.nifi.serialization.record.Record;
 import org.apache.nifi.serialization.record.RecordSchema;
 
+import avro.shaded.com.google.common.base.Throwables;
 
 Review comment:
   You are right, i didn't pay attention to the imports :-/
   
   Now I am bringing in the official / latest of guava. 
   
   I am using it to construct a user friendly message, that would end up in the 
logs / bulletin, eg.:
   <img width="1597" alt="screen shot 2019-02-01 at 10 02 16" 
src="https://user-images.githubusercontent.com/1477846/52113107-b3399500-2608-11e9-92de-f602204cdc99.png";>
   without it, it's rather cryptic why the parse failed, so it is not crucial, 
but rather useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services