[ 
https://issues.apache.org/jira/browse/MINIFICPP-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758289#comment-16758289
 ] 

Mr TheSegfault edited comment on MINIFICPP-728 at 2/1/19 1:21 PM:
------------------------------------------------------------------

[~aboda]  Not sure we have a choice with your concern, then. 

It does bring up another issue. Care if we change to title to: "Explore closing 
connections after transfer of data to and from RPG sources?"

My rationale is that we should be closing the peers ( and thus the sockets ) if 
we don't know how long it will be before new flow files will arrive ( i suspect 
we can do more to figure this out ).


was (Author: phrocker):
[~aboda]  Not sure we have a choice with your concern, then.\

It does bring up another issue. Care if we change to title to: "Explore closing 
connections after transfer of data to and from RPG sources?"

My rationale is that we should be closing the peers ( and thus the sockets ) if 
we don't know how long it will be before new flow files will arrive ( i suspect 
we can do more to figure this out ).

> RawSiteToSite::getPeerList unnecessarily tears down connection after 
> successfully retrieving peer list
> ------------------------------------------------------------------------------------------------------
>
>                 Key: MINIFICPP-728
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-728
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Minor
>             Fix For: 0.7.0
>
>
> teardown call seems to be needless in sunny path, the connection could be 
> kept after retrieving peers.
> [~phrocker] what do you think?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to