bbende commented on issue #7: NIFI-5859: Build NAR Extension Definitions/docs 
at build time
URL: https://github.com/apache/nifi-maven/pull/7#issuecomment-459769292
 
 
   @markap14 from testing this out I noticed a couple of NARs failed to 
generate the descriptor due to failing to resolve an artifact. The exception 
comes from ExtensionClassLoaderFactory toUrls method:
   ```
   final ArtifactResolutionRequest request = new ArtifactResolutionRequest();
    request.setLocalRepository(localRepo);
    request.setRemoteRepositories(remoteRepos);
   
   final ArtifactResolutionResult result = artifactResolver.resolve(request);
   if (!result.isSuccess()) {
       throw new MojoExecutionException("Could not resolve local dependency " + 
artifact);
   }
   ```
   If I comment out the setRemoteRepositories call then it appears to always 
work.
   
   I think this is safe to do since at this point you must already have the 
artifact locally to have gotten this far in building the NAR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to