jtstorck commented on a change in pull request #3279: NIFI-5984: Enabled 
Kerberos Authentication for PutKudu
URL: https://github.com/apache/nifi/pull/3279#discussion_r253583141
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/test/java/org/apache/nifi/processors/kudu/MockPutKudu.java
 ##########
 @@ -61,7 +62,7 @@ protected Upsert upsertRecordToKudu(KuduTable kuduTable, 
Record record, List<Str
     }
 
     @Override
-    protected KuduClient createClient(final String masters) {
+    protected KuduClient createClient(final String masters, final 
KerberosCredentialsService credentialsService) {
 
 Review comment:
   Could you add a test that covers the logic to create secure/unsecure 
KuduClients?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to