jtstorck commented on a change in pull request #3288: [WIP] NIFI-5985: Added
capability for DBCPConnectionPool to use KerberosCre…
URL: https://github.com/apache/nifi/pull/3288#discussion_r255234061
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
##########
@@ -413,6 +437,15 @@ protected ClassLoader getDriverClassLoader(String
locationString, String drvName
*/
@OnDisabled
public void shutdown() {
+ try {
Review comment:
@markap14 Sounds like there's no reason to throw the exceptions that occur
in an `@OnDisabled` method. Instead, I can just log them as errors and let the
method finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
