jtstorck commented on a change in pull request #3288: NIFI-5985: Added 
capability for DBCPConnectionPool to use KerberosCre…
URL: https://github.com/apache/nifi/pull/3288#discussion_r255268229
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ##########
 @@ -413,6 +437,15 @@ protected ClassLoader getDriverClassLoader(String 
locationString, String drvName
      */
     @OnDisabled
     public void shutdown() {
+        try {
 
 Review comment:
   Pushed a new commit that should take care of attempting to close the 
datasource and log out the principal, with the datasource exception being 
prioritized over the logout exception, if both occur.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to