markap14 commented on a change in pull request #3223: NIFI-5903: Allow
RecordPath to be used in QueryRecord processor. Also…
URL: https://github.com/apache/nifi/pull/3223#discussion_r255557281
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryRecord.java
##########
@@ -640,4 +667,233 @@ public Connection getConnection() {
return connection;
}
}
+
+
+ // ------------------------------------------------------------
+ // User-Defined Functions for Calcite
+ // ------------------------------------------------------------
+
+
+ public static class ObjectRecordPath extends RecordPathFunction {
Review comment:
They could be moved out if ever we found a reason to reference them
elsewhere. However, I do generally agree with the concept outlined in Joshua
Bloch's "Effective Java", that classes, in general, should be made inner
classes if they will not have any applicability outside of the outer class. In
this case, I don't think it would make sense to use the class outside of
QueryRecord.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
