Salatich commented on a change in pull request #3302: NIFI-6000 Catch also
IllegalArgumentException in ConvertAvroToORC hiv…
URL: https://github.com/apache/nifi/pull/3302#discussion_r256310662
##########
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ConvertAvroToORC.java
##########
@@ -283,8 +283,8 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
session.transfer(flowFile, REL_SUCCESS);
session.getProvenanceReporter().modifyContent(flowFile, "Converted
"+totalRecordCount.get()+" records", System.currentTimeMillis() - startTime);
- } catch (final ProcessException pe) {
- getLogger().error("Failed to convert {} from Avro to ORC due to
{}; transferring to failure", new Object[]{flowFile, pe});
+ } catch (ProcessException | IllegalArgumentException e) {
+ getLogger().error("Failed to convert {} from Avro to ORC due to
{}; transferring to failure", new Object[]{flowFile, e});
Review comment:
@mattyb149 Hi! Thx for valuable remarks. I added your commit to my PR and
squashed it. Could you review it again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
