alopresto commented on issue #3335: NIFI-5018
URL: https://github.com/apache/nifi/pull/3335#issuecomment-467271663
 
 
   Yes, the origin point is what is tracked, although that's because component 
size (other than labels) was static and unchanged since 1.0.0. With this 
change, component size may need to be tracked as well, or there could be 
inconsistencies introduced when a flow from one version is imported into an 
instance running a different version. 
   
   It's interesting that the "snap" doesn't occur until a drag event is 
registered on the component. Does this happen for all components in a 
selection/snippet if you select multiple and move them that way? I can see pros 
and cons to this -- an existing flow will not change the origin points until 
manually changed, but at the same time, if you have 1000's of components on a 
canvas, having to "snap" them individually/in groups. If a process group is 
moved, do the components contained inside that process group have their 
location modified as well?
   
   I'm in the middle of a coding on a feature branch, so I can't check out this 
PR right now to explore on my own. Usually some level of this detail is covered 
in the PR description or at least documented via unit tests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to