arpadboda commented on a change in pull request #489: MINIFICPP-740: Add 
ability to run NiFi processors from Java and Python
URL: https://github.com/apache/nifi-minifi-cpp/pull/489#discussion_r260301663
 
 

 ##########
 File path: thirdparty/pybind11/include/pybind11/pytypes.h
 ##########
 @@ -292,7 +292,7 @@ class error_already_set : public std::runtime_error {
     /// Constructs a new exception from the current Python error indicator, if 
any.  The current
     /// Python error indicator will be cleared.
     error_already_set() : std::runtime_error(detail::error_string()) {
-        PyErr_Fetch(&type.ptr(), &value.ptr(), &trace.ptr());
+        //PyErr_Fetch(&type.ptr(), &value.ptr(), &trace.ptr());
 
 Review comment:
   Don't we need this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to