R-Bower commented on issue #3335: NIFI-5018 URL: https://github.com/apache/nifi/pull/3335#issuecomment-468101470 Hey guys, thanks for all of the constructive feedback. > It's interesting that the "snap" doesn't occur until a drag event is registered on the component. Does this happen for all components in a selection/snippet if you select multiple and move them that way? I can see pros and cons to this -- an existing flow will not change the origin points until manually changed, but at the same time, if you have 1000's of components on a canvas, having to "snap" them individually/in groups. Having just tested this, I can confirm that each component does snap and align individually when multiple are selected and moved together. Let me know if you want to see the recording that I took. > If a process group is moved, do the components contained inside that process group have their location modified as well? Since the draggable event only impacts the selected canvas element(s), the inner processors for a process group shouldn't be moved. I believe that draggable states are only invoked on components selected in the current canvas "level", and not on nested components, but I haven't verified this. > **Turning this feature on/off** > Rather than always using snap-to-grid or adding a property which would set it for the entire instance what are your thoughts about conditionally snapping based on whether the drag event contains some modifier key (like Drag-Shift or something)? This seems like the best compromise. Current users would still be able to move components around as they do now, but snap alignment would also be an option. I'm unfamiliar with how nifi handles modifier keys. Since all of the controlling logic for draggable events is in nf-draggable, how would I go about accessing the activated keys? I've merely scratched the service of nifi's frontend and would appreciate some additional direction/tips!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
