AaronLeon commented on issue #2861: NIFI-5248 Added new Elasticsearch json and record processors. URL: https://github.com/apache/nifi/pull/2861#issuecomment-468371024 Regarding the REST client, I firmly believe the service should use the low-level REST client. The major difference being that the high-level client is tied to major versions of Elasticsearch (see below). This means the implementation in this PR, which uses high-level client 5.6.x, is tied to Elasticsearch 5.X. In order to support ES 6.X and the newly released ES 7.X, we would need to create a new set of NARs, similar to how the transport client processors were organized (e.g. PutElasticsearch, PutElasticsearch5, etc.) Using the low-level client requires some extra work as it does not help you build requests or unmarshall responses, but it is designed to have "compatibility with any Elasticsearch version". The good thing about the current code is that you have already created classes that encode requests and responses, e.g. IndexOperationRequest, IndexOperationResponse, which will make the change easier. https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-high-compatibility.html https://www.elastic.co/blog/state-of-the-official-elasticsearch-java-clients
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
