arpadboda commented on a change in pull request #500: MINIFICPP-741: Allow
proper error catching with PyErr_Fetch
URL: https://github.com/apache/nifi-minifi-cpp/pull/500#discussion_r263356122
##########
File path: thirdparty/pybind11/include/pybind11/pytypes.h
##########
@@ -967,6 +1009,14 @@ class none : public object {
none() : object(Py_None, borrowed_t{}) { }
};
+#if PY_MAJOR_VERSION >= 3
Review comment:
I would think it over if we have the possibility to decide.
Python 2 is already pretty old, not sure supporting that worth the effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
