thenatog commented on a change in pull request #3340: NIFI-6026 - First commit
which adds a new tls-toolkit mode called Key…
URL: https://github.com/apache/nifi/pull/3340#discussion_r264763551
##########
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/standalone/TlsToolkitStandaloneCommandLine.java
##########
@@ -122,12 +129,25 @@ public static void main(String[] args) {
} catch (CommandLineParseException e) {
System.exit(e.getExitCode().ordinal());
}
- try {
- new
TlsToolkitStandalone().createNifiKeystoresAndTrustStores(tlsToolkitStandaloneCommandLine.createConfig());
- } catch (Exception e) {
- tlsToolkitStandaloneCommandLine.printUsage("Error generating TLS
configuration. (" + e.getMessage() + ")");
- System.exit(ExitCode.ERROR_GENERATING_CONFIG.ordinal());
+
+ StandaloneConfig conf =
tlsToolkitStandaloneCommandLine.createSplitKeystoreConfig();
Review comment:
Updated this to use the command line parsed args rather than the config, and
will no longer create the config unless it's required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
