apiri commented on a change in pull request #511: Minificpp 764: Add docker
builds for different systems.
URL: https://github.com/apache/nifi-minifi-cpp/pull/511#discussion_r265996823
##########
File path: cmake/DockerConfig.cmake
##########
@@ -20,6 +20,35 @@ add_custom_target(
docker
COMMAND ${CMAKE_SOURCE_DIR}/docker/DockerBuild.sh 1000 1000
${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}
minificppsource ${CMAKE_SOURCE_DIR}
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/docker/)
+
+
+add_custom_target(
Review comment:
Do you think it might be better to just have these as their own Makefile?
If we did that, folks could get all these builds with just Docker whereas they
would also need to go through the cmake'ing and need its dependencies when it's
just formulating the targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
