mcgilman commented on a change in pull request #3351: NIFI-2933 Remote
input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#discussion_r266614839
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js
##########
@@ -1651,10 +1651,10 @@
$('#component-policy-target')
.combo('setOptionEnabled', {
value: 'write-receive-data'
- }, nfCanvasUtils.isInputPort(selection) &&
nfCanvasUtils.getParentGroupId() === null)
+ }, nfCanvasUtils.isInputPort(selection) &&
d.component.allowRemoteAccess === true)
Review comment:
Technically we can have admin permissions for a component we don't have read
permissions to. We need to check read permissions before we can directly access
`d.component`. However, in this case I think we can use the other
`allowRemoteAccess` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services