ijokarumawak commented on issue #3276: NIFI-5953 Manage GetTwitter connection retries on '420 Enhance Your C… URL: https://github.com/apache/nifi/pull/3276#issuecomment-475832292 @kourge-ch Yes, I agree with the change that not calling `client.reconnect` for any `HTTP_ERROR`. But it's still not clear if not calling `client.reconnect` makes GetTwitter more resilient against 420 situation. Because `client.reconnect` only affect hen the client gets 200 successful response. What I'm afraid is introducing any regression by stop calling `client.reconnect`. If we don't have to remove that, I'd prefer leave it as is. Would you be able to share before/after behavior by the change? I imagine calling or not calling `client.reconnect` does not matter, but increasing max retry count for 4xx status code helps. `clientBuilder.retries(10);`. How do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
