alopresto commented on issue #162: NIFIREG-238: Allow aliasing of registry url
URL: https://github.com/apache/nifi-registry/pull/162#issuecomment-476287749
 
 
   I have some questions on this feature:
   
   * How are aliases set? It appears that this only happens from an internal 
XML file at this time, but if the REST API is extended to handle this in the 
future, it exposes a number of security concerns. 
   * What happens if the value inside changes without the end user knowing 
(i.e. Kevin versions two PGs, one called *Do normal stuff* and it references 
*Do sensitive stuff*, and then Andy modifies the alias in *Do normal stuff* 
that points to *Do sensitive stuff* to point to _Andy’s version_ of *Do 
sensitive stuff* and Kevin doesn’t know about it)?
   * I understand the example `aliases.xml` is demonstrating an _internal_ 
token and an _external_ URL, but I think using `http://localhost:18080` for the 
URL is confusing as for most common understandings of those terms, it would be 
"internal", not "external". Perhaps a value like 
`http://registry.nifi.apache.org:18080` would illustrate this point more 
clearly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to